[llvm-strings] Improve testing of llvm-strings
authorJames Henderson <jh7370@my.bristol.ac.uk>
Mon, 12 Aug 2019 11:36:11 +0000 (11:36 +0000)
committerJames Henderson <jh7370@my.bristol.ac.uk>
Mon, 12 Aug 2019 11:36:11 +0000 (11:36 +0000)
commitf23ce128fd614d5ed7b5c70038c5db8b257c5127
treed3ab7548147936d4d4057564f569c0fc47426948
parentccdad6ef486a00ed815ead642d2f62d87d86ee90
[llvm-strings] Improve testing of llvm-strings

This patch tidies up the llvm-strings testing by:

1. Adding comments to every test.
2. Getting rid of canned input files, and having the tests generate
   them on the fly (this makes the tests self-contained).
3. Adding missing test coverage.
4. Renaming some tests that weren't clear as to their purpose.
5. Adding extra checking of various cases, formatting etc.
6. Removing a test that didn't seem to have any useful purpose for
   testing llvm-strings.

Reviewed by: rupprecht, grimar, MaskRay

Differential Revision: https://reviews.llvm.org/D66015

llvm-svn: 368555
23 files changed:
llvm/test/tools/llvm-strings/Inputs/abcd [deleted file]
llvm/test/tools/llvm-strings/Inputs/numbers [deleted file]
llvm/test/tools/llvm-strings/Inputs/variable-length [deleted file]
llvm/test/tools/llvm-strings/all-sections.test
llvm/test/tools/llvm-strings/archive-filename.test
llvm/test/tools/llvm-strings/eof-no-string.test [new file with mode: 0644]
llvm/test/tools/llvm-strings/eof.test [new file with mode: 0644]
llvm/test/tools/llvm-strings/file-filename.test
llvm/test/tools/llvm-strings/help.test
llvm/test/tools/llvm-strings/length.test
llvm/test/tools/llvm-strings/multiple-inputs.test [new file with mode: 0644]
llvm/test/tools/llvm-strings/negative-char.test
llvm/test/tools/llvm-strings/nested-archives.test [deleted file]
llvm/test/tools/llvm-strings/option-grouping.test [new file with mode: 0644]
llvm/test/tools/llvm-strings/radix-filename.test
llvm/test/tools/llvm-strings/radix.test
llvm/test/tools/llvm-strings/response-file.test [new file with mode: 0644]
llvm/test/tools/llvm-strings/stdin-filename.test
llvm/test/tools/llvm-strings/stdin.test [new file with mode: 0644]
llvm/test/tools/llvm-strings/terminator-neg.test [deleted file]
llvm/test/tools/llvm-strings/terminator.test [deleted file]
llvm/test/tools/llvm-strings/version.test [new file with mode: 0644]
llvm/test/tools/llvm-strings/whitespace.test