Revert "sched/wait: Suppress Sparse 'variable shadowing' warning"
authorIngo Molnar <mingo@kernel.org>
Thu, 27 Feb 2014 11:20:31 +0000 (12:20 +0100)
committerIngo Molnar <mingo@kernel.org>
Thu, 27 Feb 2014 11:20:31 +0000 (12:20 +0100)
commitf207dbe63c61158c234e2e8929a3725a7f6b2b9b
tree51488fdd8dc02b263869ca3d2262565a06b5528a
parent47be1c1a0e188232b5e5962917b21750053cd3f8
Revert "sched/wait: Suppress Sparse 'variable shadowing' warning"

This reverts commit 980f88e414418bf65569a3b62b08b07e6fc2f4c6.

This warning is actually useful, don't suppress it.

We actually rely on the shadowing for ___wait_cond_timeout().

We further used the __ret variable in __wait_event_timeout()'s cmd
argument: __ret = schedule_timeout(__ret). That now explicitly uses the
wrong __ret.

Reported-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Requested-by: Andrew Morton <akpm@linux-foundation.org>
Requested-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/n/tip-Q5blhuqqzwgVwvjf1gszrdol@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
include/linux/wait.h