Diagnose extensions in 'offsetof'
authorAaron Ballman <aaron@aaronballman.com>
Tue, 17 Jan 2023 19:26:29 +0000 (14:26 -0500)
committerAaron Ballman <aaron@aaronballman.com>
Tue, 17 Jan 2023 19:30:57 +0000 (14:30 -0500)
commitf1f0a0d8e8fdd2e534d9423b2e64c6b8aaa53aee
treebfd158a73917a5baa36d973aeb1ad13595cbc9ca
parent09e4449901d7fc780806778181cf3136c1e08e98
Diagnose extensions in 'offsetof'

https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2350.htm made very
clear that it is an UB having type definitions with in offsetof.
Clang supports defining a type as the first argument as a conforming
extension due to how many projects use the construct in C99 and earlier
to calculate the alignment of a type. GCC also supports defining a type
as the first argument.

This adds extension warnings and documentation for the functionality
Clang explicitly supports.

Fixes #57065

Co-authored-by: Yingchi Long <i@lyc.dev>
Co-authored-by: Aaron Ballman <aaron@aaronballman.com>
19 files changed:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.rst
clang/include/clang/Basic/DiagnosticGroups.td
clang/include/clang/Basic/DiagnosticParseKinds.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/clang/Parse/Parser.h
clang/include/clang/Parse/RAIIObjectsForParser.h
clang/include/clang/Sema/Sema.h
clang/lib/Parse/ParseDecl.cpp
clang/lib/Parse/ParseDeclCXX.cpp
clang/lib/Parse/ParseExpr.cpp
clang/lib/Sema/SemaDecl.cpp
clang/lib/Sema/SemaDeclCXX.cpp
clang/lib/Sema/SemaTemplate.cpp
clang/test/C/C2x/n2350.c [new file with mode: 0644]
clang/test/C/drs/dr4xx.c
clang/test/CXX/drs/dr4xx.cpp
clang/test/Parser/declarators.c
clang/test/SemaCXX/offsetof.cpp