projects / kernel / kernel-generic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 67b9124) | patch
iop-adma: redundant/wrong tests in iop_*_count()?
authorRoel Kluin <roel.kluin@gmail.com>
Sat, 13 Feb 2010 14:54:03 +0000 (15:54 +0100)
committerDan Williams <dan.j.williams@intel.com>
Mon, 1 Mar 2010 05:22:12 +0000 (22:22 -0700)
commitf1acb878b6070941e844dfc4ca1b3b9e5a70426c
treeee42486424fea38a50136f95379b4bc42d0c3d5ftree | snapshot
parent67b9124f734b22b30d9adf18c39fe795e2901070commit | diff
iop-adma: redundant/wrong tests in iop_*_count()?

When we reach the loop, len is at least 1, we only stay in the loop when
len is at least MAX_BYTE_COUNT + 1, MAX_BYTE_COUNT is subtracted in each
iteration. So when we leave the loop, or didn't take it, len is at least 1.
Testing whether len is non-zero appears redundant.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
arch/arm/include/asm/hardware/iop3xx-adma.h diff | blob | history
Domain: System / Uncategorized;