Replace SkPicture(SkStream) constructors with a factory.
authorscroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>
Fri, 28 Jun 2013 21:32:00 +0000 (21:32 +0000)
committerscroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>
Fri, 28 Jun 2013 21:32:00 +0000 (21:32 +0000)
commitf1754ec69131801c1a6ed3c704501a9400bbf324
tree1a54d42c519ed1d15b25ed291f04274cbb0d0120
parent925cdca8055fe6d6aab7c271d93d224d9b4e4fc8
Replace SkPicture(SkStream) constructors with a factory.

SkPicture:
Remove the constructors which take an SkStream as an argument. Rather
than having to check a variable for success, the factory will return
NULL on failure.
Add a protected function for determining if an SkStream is an SKP
to share code with SkTimedPicture.
In the factory, check for a NULL SkStream.
Use a default decoder (from BUG:
https://code.google.com/p/skia/issues/detail?id=1325)

SkDebuggerGUI:
Call SkPicture::CreateFromStream when necessary.
Write a factory for creating SkTimedPictures and use it.

Use the factory throughout tools.

Add include/lazy to utils and effects gyp include_dirs so SkPicture.h
can reference SkImageDecoder.h which references SkBitmapFactory.h (in
include/lazy).

Changes code Chromium uses, so this will require a temporary Skia
and then a change to Chromium to use the new Skia code.

TODO: Create a decoder that does nothing to be used by pinspect,
lua pictures, etc, and allow it to not assert in SkOrderedReadBuffer.

R=reed@google.com

Review URL: https://codereview.chromium.org/17113004

git-svn-id: http://skia.googlecode.com/svn/trunk@9822 2bbb7eff-a529-9590-31e7-b0007b416f81
16 files changed:
debugger/QT/SkDebuggerGUI.cpp
gm/gmmain.cpp
gyp/effects.gyp
gyp/utils.gyp
include/core/SkPicture.h
samplecode/SampleApp.cpp
samplecode/SamplePictFile.cpp
src/core/SkPicture.cpp
src/core/SkPicturePlayback.cpp
tests/PictureTest.cpp
tools/bench_pictures_main.cpp
tools/filtermain.cpp
tools/lua/lua_pictures.cpp
tools/pinspect.cpp
tools/render_pdfs_main.cpp
tools/render_pictures_main.cpp