clk: Return errors from clk providers in __of_clk_get_from_provider()
authorStephen Boyd <sboyd@codeaurora.org>
Mon, 15 Aug 2016 21:32:23 +0000 (14:32 -0700)
committerStephen Boyd <sboyd@codeaurora.org>
Mon, 15 Aug 2016 21:32:23 +0000 (14:32 -0700)
commitf155d15b64e36b45ca89e3521fe0c1ccad5e5ff0
tree5e274853713d1e438f2e49d4c9e9578132ac72b6
parent00746f104420e79efb2dd30467a3546c790b30eb
clk: Return errors from clk providers in __of_clk_get_from_provider()

Before commit 0861e5b8cf80 (clk: Add clk_hw OF clk providers,
2016-02-05) __of_clk_get_from_provider() would return an error
pointer of the provider's choosing if there was a provider
registered and EPROBE_DEFER otherwise. After that commit, it
would return EPROBE_DEFER regardless of whether or not the
provider returned an error. This is odd and can lead to behavior
where clk consumers keep probe deferring when they should be
seeing some other error.

Let's restore the previous behavior where we only return
EPROBE_DEFER when there isn't a provider in our of_clk_providers
list. Otherwise, return the error from the last provider we find
that matches the node.

Reported-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Fixes: 0861e5b8cf80 ("clk: Add clk_hw OF clk providers")
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/clk.c