[clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting
authorBalázs Kéri <balazs.keri@ericsson.com>
Tue, 18 Jul 2023 06:47:40 +0000 (08:47 +0200)
committerBalázs Kéri <balazs.keri@ericsson.com>
Tue, 18 Jul 2023 07:29:15 +0000 (09:29 +0200)
commitf12808ab20369c85ddb602e5a78bab40d16bb83f
tree1d10edc97c27f5e7cb2a5e9116154157aa126da4
parent39670ae3b93470b2d29fe78e6d40c5d82a05e4a1
[clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

The note tag that was previously added in all cases when a standard function call
is found is displayed now only if the function call (return value) is "interesting".
This results in less unneeded notes but some of the previously good notes disappear
too. This is because interestingness is not always set as it should be.

Reviewed By: donat.nagy

Differential Revision: https://reviews.llvm.org/D153776
clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
clang/test/Analysis/errno-stdlibraryfunctions-notes.c
clang/test/Analysis/std-c-library-functions-arg-constraints-note-tags.cpp
clang/test/Analysis/std-c-library-functions-arg-constraints.c
clang/test/Analysis/std-c-library-functions-path-notes.c
clang/test/Analysis/stream-errno-note.c
clang/test/Analysis/stream-note.c