media: uvcvideo: Fix memory leak in uvc_gpio_parse
authorJosé Expósito <jose.exposito89@gmail.com>
Sat, 8 Jan 2022 17:04:39 +0000 (18:04 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Tue, 30 Aug 2022 14:04:19 +0000 (16:04 +0200)
commitf0f078457f18f10696888f8d0e6aba9deb9cde92
tree049209cd3042a233d2284997c74747d6bdf6f888
parent882bda188f691320a001c6adc738c4a7ec102a8d
media: uvcvideo: Fix memory leak in uvc_gpio_parse

Previously the unit buffer was allocated before checking the IRQ for
privacy GPIO. In case of error, the unit buffer was leaked.

Allocate the unit buffer after the IRQ to avoid it.

Addresses-Coverity-ID: 1474639 ("Resource leak")

Fixes: 2886477ff987 ("media: uvcvideo: Implement UVC_EXT_GPIO_UNIT")
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/usb/uvc/uvc_driver.c