Hexagon: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 30 May 2023 16:26:08 +0000 (16:26 +0000)
committerKees Cook <keescook@chromium.org>
Wed, 14 Jun 2023 18:18:05 +0000 (11:18 -0700)
commitf0e212de87a1c7884d011da714418a9b18823f7d
tree86d7d1afc0f489c4692ec5b5cc4d5928a2ac9f27
parentb2f10148ec1eae7d63dd6a1a56afdf93a27daa74
Hexagon: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230530162608.984333-1-azeemshaikh38@gmail.com
arch/hexagon/kernel/setup.c