eth: ixgbe: fix the wake condition
authorJakub Kicinski <kuba@kernel.org>
Wed, 7 Jun 2023 01:08:26 +0000 (18:08 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 8 Jun 2023 04:53:11 +0000 (21:53 -0700)
commitf0d751973f739feb3742d4e5f4c0914e8b84e7c7
tree5ffe9c05a4e1bcca51e758e2220fd773dd890379
parent649c3fed36730a53447d8f479c14e431363563b6
eth: ixgbe: fix the wake condition

Flip the netif_carrier_ok() condition in queue wake logic.
When I moved it to inside __netif_txq_completed_wake()
I missed negating it.

This made the condition ineffective and could probably
lead to crashes.

Fixes: 301f227fc860 ("net: piggy back on the memory barrier in bql when waking queues")
Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Link: https://lore.kernel.org/r/20230607010826.960226-2-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c