blk-mq: fix use-after-free in blk_mq_exit_sched
authorMing Lei <ming.lei@redhat.com>
Wed, 9 Jun 2021 06:30:46 +0000 (14:30 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 18 Jun 2021 14:50:13 +0000 (08:50 -0600)
commitf0c1c4d2864ed614f90d2da1bab1a1c42907b940
tree85839bf9a39f116ce20217df43d358ad4571e41c
parent828615950b5876e75587fdd5e9d1185be9cabba7
blk-mq: fix use-after-free in blk_mq_exit_sched

tagset can't be used after blk_cleanup_queue() is returned because
freeing tagset usually follows blk_clenup_queue(). Commit d97e594c5166
("blk-mq: Use request queue-wide tags for tagset-wide sbitmap") adds
check on q->tag_set->flags in blk_mq_exit_sched(), and causes
use-after-free.

Fixes it by using hctx->flags.

Reported-by: syzbot+77ba3d171a25c56756ea@syzkaller.appspotmail.com
Fixes: d97e594c5166 ("blk-mq: Use request queue-wide tags for tagset-wide sbitmap")
Cc: John Garry <john.garry@huawei.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Tested-by: John Garry <john.garry@huawei.com>
Reviewed-by: John Garry <john.garry@huawei.com>
Link: https://lore.kernel.org/r/20210609063046.122843-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq-sched.c