virtio_balloon: prevent uninitialized variable use
authorArnd Bergmann <arnd@arndb.de>
Tue, 28 Mar 2017 16:46:59 +0000 (18:46 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 28 Mar 2017 17:41:28 +0000 (20:41 +0300)
commitf0bb2d50dfcc519f06f901aac88502be6ff1df2c
tree11716cb90806e4de4adb2ae4e89334da92bb5dca
parent9646b26e85896ef0256e66649f7937f774dc18a6
virtio_balloon: prevent uninitialized variable use

The latest gcc-7.0.1 snapshot reports a new warning:

virtio/virtio_balloon.c: In function 'update_balloon_stats':
virtio/virtio_balloon.c:258:26: error: 'events[2]' is used uninitialized in this function [-Werror=uninitialized]
virtio/virtio_balloon.c:260:26: error: 'events[3]' is used uninitialized in this function [-Werror=uninitialized]
virtio/virtio_balloon.c:261:56: error: 'events[18]' is used uninitialized in this function [-Werror=uninitialized]
virtio/virtio_balloon.c:262:56: error: 'events[17]' is used uninitialized in this function [-Werror=uninitialized]

This seems absolutely right, so we should add an extra check to
prevent copying uninitialized stack data into the statistics.
>From all I can tell, this has been broken since the statistics code
was originally added in 2.6.34.

Fixes: 9564e138b1f6 ("virtio: Add memory statistics reporting to the balloon driver (V4)")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Ladi Prosek <lprosek@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/virtio/virtio_balloon.c