userns: Don't allow setgroups until a gid mapping has been setablished
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 6 Dec 2014 00:01:11 +0000 (18:01 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2015 18:00:50 +0000 (10:00 -0800)
commitf077e88fc9f0befcf0441be2fed9516881ab02ef
tree75071c6d3e84f07f38592707615ac3a9bbc8c66c
parent096b0c8d7033ef56d4c0eb13a29865a021eedea5
userns: Don't allow setgroups until a gid mapping has been setablished

commit 273d2c67c3e179adb1e74f403d1e9a06e3f841b5 upstream.

setgroups is unique in not needing a valid mapping before it can be called,
in the case of setgroups(0, NULL) which drops all supplemental groups.

The design of the user namespace assumes that CAP_SETGID can not actually
be used until a gid mapping is established.  Therefore add a helper function
to see if the user namespace gid mapping has been established and call
that function in the setgroups permission check.

This is part of the fix for CVE-2014-8989, being able to drop groups
without privilege using user namespaces.

Reviewed-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/user_namespace.h
kernel/groups.c
kernel/user_namespace.c