tracepoint: Use struct_size() in kmalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 10 Jun 2019 21:22:19 +0000 (16:22 -0500)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Tue, 18 Jun 2019 01:13:32 +0000 (21:13 -0400)
commitf0553dcb9778c343641d3a41f1db01be02e7551b
tree57bd41c1a8ec0429b3f42ab6578743d9f6c8ee89
parent86b3de60a0b634cdcef82d0a2091bc5444a00020
tracepoint: Use struct_size() in kmalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct tp_probes {
...
        struct tracepoint_func probes[0];
};

instance = kmalloc(sizeof(sizeof(struct tp_probes) +
sizeof(struct tracepoint_func) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kmalloc(struct_size(instance, probes, count) GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/tracepoint.c