ALSA: hda/via: Avoid potential array out-of-bound in add_secret_dac_path()
authorArtemii Karasev <karasev@ispras.ru>
Thu, 19 Jan 2023 08:22:59 +0000 (00:22 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Feb 2023 10:28:01 +0000 (11:28 +0100)
commitf011360ad234a07cb6fbcc720fff646a93a9f0d6
treee6494936925a33c15ad8608cbcb5341ae6de38cd
parent6a199d556c0255a58023416ece1320305dd53c12
ALSA: hda/via: Avoid potential array out-of-bound in add_secret_dac_path()

[ Upstream commit b9cee506da2b7920b5ea02ccd8e78a907d0ee7aa ]

snd_hda_get_connections() can return a negative error code.
It may lead to accessing 'conn' array at a negative index.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Artemii Karasev <karasev@ispras.ru>
Fixes: 30b4503378c9 ("ALSA: hda - Expose secret DAC-AA connection of some VIA codecs")
Link: https://lore.kernel.org/r/20230119082259.3634-1-karasev@ispras.ru
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/hda/patch_via.c