i2c: i801: Don't silently correct invalid transfer size
authorHeiner Kallweit <hkallweit1@gmail.com>
Sun, 7 Nov 2021 21:57:00 +0000 (22:57 +0100)
committerWolfram Sang <wsa@kernel.org>
Mon, 29 Nov 2021 08:53:56 +0000 (09:53 +0100)
commiteffa453168a7eeb8a562ff4edc1dbf9067360a61
treee74a44a61e247c7ce5d993b6757db5936b4f8531
parentbd2fdedbf2bac27f4a2ac16b84ab9b9e5f67006c
i2c: i801: Don't silently correct invalid transfer size

If an invalid block size is provided, reject it instead of silently
changing it to a supported value. Especially critical I see the case of
a write transfer with block length 0. In this case we have no guarantee
that the byte we would write is valid. When silently reducing a read to
32 bytes then we don't return an error and the caller may falsely
assume that we returned the full requested data.

If this change should break any (broken) caller, then I think we should
fix the caller.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-i801.c