follow_dotdot_rcu(): be lazy about changing nd->path
authorAl Viro <viro@zeniv.linux.org.uk>
Fri, 28 Feb 2020 15:06:37 +0000 (10:06 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 2 Apr 2020 05:09:20 +0000 (01:09 -0400)
commitefe772d6283b3672c0880b10fc4ceea69bc782ca
tree054b34fde4b19c080bcb55803a9a5fc1a0fb1bd3
parent12487f3067d8d68a90dd2fc0dbc2a287ae699236
follow_dotdot_rcu(): be lazy about changing nd->path

Change nd->path only after the loop is done and only in case we hadn't
ended up finding ourselves in root.  Same for NO_XDEV check.  Don't
recheck mount_lock on each step either.

That separates the "check how far back do we need to go through the
mount stack" logics from the rest of .. traversal.

Note that the sequence for d_seq/d_inode here is
* sample mount_lock seqcount
...
* sample d_seq
* fetch d_inode
* verify mount_lock seqcount
The last step makes sure that d_inode value we'd got matches d_seq -
it dentry is guaranteed to have been a mountpoint through the
entire thing, so its d_inode must have been stable.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namei.c