platform/x86: intel_scu_ipc: Don't override scu in intel_scu_ipc_dev_simple_command()
authorStephen Boyd <swboyd@chromium.org>
Wed, 13 Sep 2023 21:27:21 +0000 (14:27 -0700)
committerHans de Goede <hdegoede@redhat.com>
Mon, 18 Sep 2023 13:15:02 +0000 (15:15 +0200)
commitefce78584e583226e9a1f6cb2fb555d6ff47c3e7
treedb3339bffaaf60bb6e579d3bad97bf6012608d0e
parent427fada620733e6474d783ae6037a66eae42bf8c
platform/x86: intel_scu_ipc: Don't override scu in intel_scu_ipc_dev_simple_command()

Andy discovered this bug during patch review. The 'scu' argument to this
function shouldn't be overridden by the function itself. It doesn't make
any sense. Looking at the commit history, we see that commit
f57fa18583f5 ("platform/x86: intel_scu_ipc: Introduce new SCU IPC API")
removed the setting of the scu to ipcdev in other functions, but not
this one. That was an oversight. Remove this line so that we stop
overriding the scu instance that is used by this function.

Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Closes: https://lore.kernel.org/r/ZPjdZ3xNmBEBvNiS@smile.fi.intel.com
Cc: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Fixes: f57fa18583f5 ("platform/x86: intel_scu_ipc: Introduce new SCU IPC API")
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20230913212723.3055315-4-swboyd@chromium.org
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel_scu_ipc.c