staging: lustre: potential underflow in mdc_iocontrol()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 6 Jan 2015 09:57:08 +0000 (12:57 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Jan 2015 23:58:30 +0000 (15:58 -0800)
commitef4356bf0cf7ed2c9aed45dd64d73538da023718
tree219d275385ec5b9fde9651cd799f57f1eea95b13
parentd372a4cdfaa62943286a0da338c2b18c7d55a1b3
staging: lustre: potential underflow in mdc_iocontrol()

Smatch complains that "data->ioc_plen2" is a user controlled value and,
since we cast to signed int, the limit check can underflow.  It's not
very serious because probably the copy_to_user() would return -EFAULT
on every arch that matters instead of creating an info leak.  Also I
haven't followed it through to see if the value is really user
controlled.

But definitely it would be safer to cast to unsigned so let's do that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/mdc/mdc_request.c