dma-buf: call dma_buf_stats_setup after dmabuf is in valid list
authorCharan Teja Reddy <quic_charante@quicinc.com>
Mon, 9 May 2022 19:49:57 +0000 (01:19 +0530)
committerChristian König <christian.koenig@amd.com>
Tue, 10 May 2022 09:30:51 +0000 (11:30 +0200)
commitef3a6b70507a2add2cd2e01f5eb9b54d561bacb9
tree29627e51c126c38a890a2684613b3bba7f5585e2
parent1b5853dfab7fdde450f00f145327342238135c8a
dma-buf: call dma_buf_stats_setup after dmabuf is in valid list

When dma_buf_stats_setup() fails, it closes the dmabuf file which
results into the calling of dma_buf_file_release() where it does
list_del(&dmabuf->list_node) with out first adding it to the proper
list. This is resulting into panic in the below path:
__list_del_entry_valid+0x38/0xac
dma_buf_file_release+0x74/0x158
__fput+0xf4/0x428
____fput+0x14/0x24
task_work_run+0x178/0x24c
do_notify_resume+0x194/0x264
work_pending+0xc/0x5f0

Fix it by moving the dma_buf_stats_setup() after dmabuf is added to the
list.

Fixes: bdb8d06dfefd ("dmabuf: Add the capability to expose DMA-BUF stats in sysfs")
Signed-off-by: Charan Teja Reddy <quic_charante@quicinc.com>
Tested-by: T.J. Mercier <tjmercier@google.com>
Acked-by: T.J. Mercier <tjmercier@google.com>
Cc: <stable@vger.kernel.org> # 5.15.x+
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1652125797-2043-1-git-send-email-quic_charante@quicinc.com
drivers/dma-buf/dma-buf.c