HID: amd_sfh: Fix potential NULL pointer dereference
authorEvgeny Novikov <novikov@ispras.ru>
Tue, 1 Jun 2021 16:38:01 +0000 (19:38 +0300)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 30 Sep 2021 08:08:03 +0000 (10:08 +0200)
commitef11357046512918ab876aa0f837b0a6de65a3c6
tree83f4d1a0850de9bf1125ec79f68ee2c0a4baa2b1
parent94f9c3567eba2a2adcaafa936fc86854546580a4
HID: amd_sfh: Fix potential NULL pointer dereference

devm_add_action_or_reset() can suddenly invoke amd_mp2_pci_remove() at
registration that will cause NULL pointer dereference since
corresponding data is not initialized yet. The patch moves
initialization of data before devm_add_action_or_reset().

Found by Linux Driver Verification project (linuxtesting.org).

[jkosina@suse.cz: rebase]
Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c