[lldb/Plugins] Move SBTarget::GetExtendedCrashInformation to SBProcess
authorMed Ismail Bennani <medismail.bennani@gmail.com>
Mon, 24 Feb 2020 15:04:16 +0000 (10:04 -0500)
committerMed Ismail Bennani <medismail.bennani@gmail.com>
Mon, 24 Feb 2020 22:37:04 +0000 (23:37 +0100)
commiteefda18227a2faeacbd5420cb482fa8b5836283b
tree197807b5585d8eb5682d626657ef6dd8661644e5
parent698078257285a044110620d7dab2fb4451a3fa29
[lldb/Plugins] Move SBTarget::GetExtendedCrashInformation to SBProcess

This patch moves the SB API method GetExtendedCrashInformation from
SBTarget to SBProcess since it only makes sense to call this method on a
sane process which might not be the case on a SBTarget object.

It also addresses some feedbacks received after landing the first patch
for the 'crash-info' feature.

Differential Revision: https://reviews.llvm.org/D75049

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
13 files changed:
lldb/bindings/interface/SBProcess.i
lldb/bindings/interface/SBTarget.i
lldb/include/lldb/API/SBProcess.h
lldb/include/lldb/API/SBStructuredData.h
lldb/include/lldb/API/SBTarget.h
lldb/include/lldb/Target/Platform.h
lldb/source/API/SBProcess.cpp
lldb/source/API/SBTarget.cpp
lldb/source/Commands/CommandObjectProcess.cpp
lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h
lldb/test/API/functionalities/process_crash_info/TestProcessCrashInfo.py
lldb/test/API/functionalities/process_crash_info/main.c