jbd2: don't write superblock when if its empty
authorEric Sandeen <sandeen@redhat.com>
Sun, 19 Aug 2012 02:29:40 +0000 (22:29 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 19 Aug 2012 02:29:40 +0000 (22:29 -0400)
commiteeecef0af5ea4efd763c9554cf2bd80fc4a0efd3
tree161c471b03b931d2e439d7c8ab6e03d5a75a8709
parentcaecd0af8fe0635e8e6900399b951433af35bf52
jbd2: don't write superblock when if its empty

This sequence:

# truncate --size=1g fsfile
# mkfs.ext4 -F fsfile
# mount -o loop,ro fsfile /mnt
# umount /mnt
# dmesg | tail

results in an IO error when unmounting the RO filesystem:

[  318.020828] Buffer I/O error on device loop1, logical block 196608
[  318.027024] lost page write due to I/O error on loop1
[  318.032088] JBD2: Error -5 detected when updating journal superblock for loop1-8.

This was a regression introduced by commit 24bcc89c7e7c: "jbd2: split
updating of journal superblock and marking journal empty".

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
fs/jbd2/journal.c