Simplify SelectionControllerEfl::OnMouseMove
authorAntonio Gomes <a1.gomes@samsung.com>
Wed, 19 Aug 2015 15:18:45 +0000 (11:18 -0400)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 06:57:09 +0000 (06:57 +0000)
commiteecd11a190332b5f93537381e6bfbee50ef85488
tree8df4d48762ae54ff27d077ae3553bf21368a7ecc
parent561ed5d6f34b7be8210b956b9aa9177126f1bb7a
Simplify SelectionControllerEfl::OnMouseMove

By passing the SelectionHandleEfl object as a parameter
instead of its type, we can greatly simplify this method.

For instance, patch factors out the magnifier positioning
logic out of the switch, now that it is common for all 3
types of handles.

Additionally, now two cases in the 'switch' statement can be
colapsed (ones that handle HANDLE_TYPE_LEFT and RIGHT).

Last, patch also moves the declaration of the
local variables within the scope they are needed.

Original beta/m42 patch:
- http://165.213.202.130/gerrit/#/c/85428/ , reviewed by
Janusz Majnert, Arnaud Renevier.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=14304

Reviewed by: Janusz Majnert

Change-Id: Ie1b8a105e155e54e33e267d1ba70243a57234bd5
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
tizen_src/chromium_impl/content/browser/selection/selection_controller_efl.cc
tizen_src/chromium_impl/content/browser/selection/selection_controller_efl.h
tizen_src/chromium_impl/content/browser/selection/selection_handle_efl.cc
tizen_src/chromium_impl/content/browser/selection/selection_handle_efl.h