terminal: Fix unintended fallthrough to cursor restore
authorDaniel Stone <daniels@collabora.com>
Tue, 3 Apr 2018 18:38:09 +0000 (19:38 +0100)
committerDerek Foreman <derekf@osg.samsung.com>
Thu, 5 Apr 2018 15:31:20 +0000 (10:31 -0500)
commitee96ce2fc2ac54f61316ecc357c2777f30da5f92
tree57d5d2ddf9430145cf11520d8e89f28f6d997b11
parent10fe82fe2d45f19e4df96e77d21fb11564c3398a
terminal: Fix unintended fallthrough to cursor restore

ef57a9b788 added support for window operations such as reporting the
title in escape mode. It implemented this by which-window-op case,
inside the existing which-escape-code case. Whilst it would break out of
the former window-op case, it never broke out of the latter escape-code
case. This would lead to window ops (such as reporting title) falling
through to restoring the saved cursor position.

This doesn't seem at all right, and also fixes a warning with GCC 8.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Derek Foreman <derekf@osg.samsung.com>
clients/terminal.c