x86-64 strncmp family: Properly handle the length parameter [BZ# 24097]
authorH.J. Lu <hjl.tools@gmail.com>
Mon, 21 Jan 2019 19:33:52 +0000 (11:33 -0800)
committerH.J. Lu <hjl.tools@gmail.com>
Mon, 21 Jan 2019 19:34:04 +0000 (11:34 -0800)
commitee915088a0231cd421054dbd8abab7aadf331153
treebda23563b2fe03f78a95219922c8fecf6a86f9df
parent82d0b4a4d76db554eb6757acb790fcea30b19965
x86-64 strncmp family: Properly handle the length parameter [BZ# 24097]

On x32, the size_t parameter may be passed in the lower 32 bits of a
64-bit register with the non-zero upper 32 bits.  The string/memory
functions written in assembly can only use the lower 32 bits of a
64-bit register as length or must clear the upper 32 bits before using
the full 64-bit register for length.

This pach fixes the strncmp family for x32.  Tested on x86-64 and x32.
On x86-64, libc.so is the same with and withou the fix.

[BZ# 24097]
CVE-2019-6488
* sysdeps/x86_64/multiarch/strcmp-avx2.S: Use RDX_LP for length.
* sysdeps/x86_64/multiarch/strcmp-sse42.S: Likewise.
* sysdeps/x86_64/strcmp.S: Likewise.
* sysdeps/x86_64/x32/Makefile (tests): Add tst-size_t-strncasecmp,
tst-size_t-strncmp and tst-size_t-wcsncmp.
* sysdeps/x86_64/x32/tst-size_t-strncasecmp.c: New file.
* sysdeps/x86_64/x32/tst-size_t-strncmp.c: Likewise.
* sysdeps/x86_64/x32/tst-size_t-wcsncmp.c: Likewise.
ChangeLog
sysdeps/x86_64/multiarch/strcmp-avx2.S
sysdeps/x86_64/multiarch/strcmp-sse42.S
sysdeps/x86_64/strcmp.S
sysdeps/x86_64/x32/Makefile
sysdeps/x86_64/x32/tst-size_t-strncasecmp.c [new file with mode: 0644]
sysdeps/x86_64/x32/tst-size_t-strncmp.c [new file with mode: 0644]
sysdeps/x86_64/x32/tst-size_t-wcsncmp.c [new file with mode: 0644]