[VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.
authorVolodymyr Sapsai <vsapsai@apple.com>
Wed, 24 Oct 2018 22:39:38 +0000 (22:39 +0000)
committerVolodymyr Sapsai <vsapsai@apple.com>
Wed, 24 Oct 2018 22:39:38 +0000 (22:39 +0000)
commitee89b2e01dfb29ceb58748f9a8ad173430a01d18
tree8850ac78d4c7b57a8f0e5b1a1bf2841518ac3437
parent5e707cb274911a76e129c1faa71dd95d2b580101
[VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.

'ignore-non-existent-contents' stopped working after r342232 in a way
that the actual attribute value isn't used and it works as if it is
always `true`.

Common use case for VFS iteration is iterating through files in umbrella
directories for modules. Ability to detect if some VFS entries point to
non-existing files is nice but non-critical. Instead of adding back
support for `'ignore-non-existent-contents': false` I am removing the
attribute, because such scenario isn't used widely enough and stricter
checks don't provide enough value to justify the maintenance.

rdar://problem/45176119

Reviewers: bruno

Reviewed By: bruno

Subscribers: hiraditya, dexonsmith, sammccall, cfe-commits

Differential Revision: https://reviews.llvm.org/D53228

llvm-svn: 345212
clang/lib/Frontend/ModuleDependencyCollector.cpp
clang/test/Modules/crash-vfs-headermaps.m
clang/test/Modules/crash-vfs-include-pch.m
clang/test/Modules/crash-vfs-ivfsoverlay.m
clang/test/Modules/crash-vfs-relative-incdir.m
clang/test/Modules/crash-vfs-run-reproducer.m
clang/test/VFS/Inputs/MissingVFS/vfsoverlay.yaml
clang/test/VFS/Inputs/Nonmodular/nonmodular-headers.yaml
clang/test/VFS/Inputs/bar-headers.yaml
clang/test/VFS/Inputs/vfsoverlay2.yaml