Produce mostly empty Microsoft.NETCore.App (dotnet/core-setup#5893)
authorDavis Goodin <dagood@users.noreply.github.com>
Tue, 23 Apr 2019 15:50:50 +0000 (10:50 -0500)
committerGitHub <noreply@github.com>
Tue, 23 Apr 2019 15:50:50 +0000 (10:50 -0500)
commitee86f5b2f3a9411de556c261f35fed762d7f8dac
tree7849d783d0ece2a17d4ec8acd045fd4abcf1ee51
parent77c445684f0d78d8eb384262dda199a14254c4f5
 Produce mostly empty Microsoft.NETCore.App (dotnet/core-setup#5893)

* Produce mostly empty Microsoft.NETCore.App

Package is now empty with a platforms package dependency. Create Microsoft.NETCore.App.Insertion transport package for compatibility workarounds.

This commit also moves netcoreapp sfx generation to the new infrastructure to more easily handle the migration away from Microsoft.NETCore.App.

* Test workarounds for Msft.NETCore.App.Insertion

If tests use MNA, use MNAI.

* M.NETCore.App.Insertion => M.NETCore.App.Internal

It isn't just for insertion into core-sdk, we use it in core-setup too for now.

* Update dir.props: quote '/' and '\' in comment

Co-Authored-By: dagood <dagood@users.noreply.github.com>
* Comment on explicit .lib exclusion

Commit migrated from https://github.com/dotnet/core-setup/commit/0752a1798f8a089aa78796068a43b52ee1564aa5
30 files changed:
eng/jobs/windows-build.yml
src/installer/TestProjects.props
src/installer/config.json
src/installer/dir.proj
src/installer/pkg/packaging-tools/framework.packaging.targets
src/installer/pkg/packaging-tools/packaging-tools.targets
src/installer/pkg/packaging-tools/sharedFramework/sharedFramework.csproj
src/installer/pkg/packaging-tools/windows/sharedFramework/breadcrumbstorefolder.wxs [new file with mode: 0644]
src/installer/pkg/packaging-tools/windows/sharedFramework/product.wxs
src/installer/pkg/packaging-tools/windows/sharedFramework/werrelatedkeys.wxs [new file with mode: 0644]
src/installer/pkg/packaging-tools/windows/wix.targets
src/installer/pkg/packaging/windows/package.targets
src/installer/pkg/packaging/windows/sharedframework/generatemsi.ps1 [deleted file]
src/installer/pkg/packaging/windows/sharedframework/provider.wxs [deleted file]
src/installer/pkg/packaging/windows/sharedframework/registrykeys.wxs [deleted file]
src/installer/pkg/packaging/windows/sharedframework/sharedframework.wxs [deleted file]
src/installer/pkg/projects/descriptions.json
src/installer/pkg/projects/netcoreapp/pkg/Microsoft.NETCore.App.Internal.pkgproj [new file with mode: 0644]
src/installer/pkg/projects/netcoreapp/pkg/Microsoft.NETCore.App.pkgproj
src/installer/pkg/projects/netcoreapp/pkg/Microsoft.NETCore.App.targets [deleted file]
src/installer/pkg/projects/netcoreapp/pkg/dir.props
src/installer/sharedFramework/framework/Program.cs [deleted file]
src/installer/sharedFramework/framework/framework.csproj [deleted file]
src/installer/sharedFramework/lockedhost/lockedhost.csproj [deleted file]
src/installer/sharedFramework/sharedFramework.proj [deleted file]
src/installer/test/Assets/TestProjects/Directory.Build.props [new file with mode: 0644]
src/installer/test/Assets/TestProjects/MNADeprecationWorkaround.props [new file with mode: 0644]
src/installer/test/Assets/TestProjects/PortableApp/PortableApp.csproj
src/installer/test/Assets/TestProjects/StandaloneApp20/Directory.Build.props [new file with mode: 0644]
src/installer/test/Assets/TestProjects/StandaloneApp21/Directory.Build.props [new file with mode: 0644]