rtpsession: don't act on suspicious BYE RTCP
authorMikhail Fludkov <misha@pexip.com>
Mon, 25 Jan 2016 15:25:51 +0000 (16:25 +0100)
committerSebastian Dröge <sebastian@centricular.com>
Fri, 20 May 2016 06:28:39 +0000 (09:28 +0300)
commitee7e80d615a718fd9c37be06b26cc3b7a43c2997
tree1b05e89fd0f5b942c4321bfebe927e51ef14a904
parentfa1c711a2f815a8c86c4ae3c4bf513bf80b0e1bf
rtpsession: don't act on suspicious BYE RTCP

Some endpoints (like Tandberg E20) can send BYE packet containing our
internal SSRC. I this case we would detect SSRC collision and get rid
of the source at some point. But because we are still sending packets
with that SSRC the source will be recreated immediately.
This brand new internal source will not have some variables incorrectly
set in its state. For example 'seqnum-base` and `clock-rate` values will be
-1.
The fix is not to act on BYE RTCP if it contains internal or unknown
SSRC.

https://bugzilla.gnome.org/show_bug.cgi?id=762219
gst/rtpmanager/rtpsession.c
tests/check/Makefile.am
tests/check/elements/rtpsession.c