usb: gadget: function: printer: Replace strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Thu, 15 Jun 2023 18:03:18 +0000 (18:03 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jun 2023 13:34:40 +0000 (15:34 +0200)
commitee400a1be11527e1ea58b716b338b9fb6665b8d6
tree47f9b2631f9dc00af16fa2b38ff958e86ae1f13a
parent8be558dcffe69b078b34b1fa93b82acaf4ce4957
usb: gadget: function: printer: Replace strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().

Direct replacement is safe here since return value of -errno
is used to check for truncation instead of PAGE_SIZE.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Link: https://lore.kernel.org/r/20230615180318.400639-1-azeemshaikh38@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/f_printer.c