iscsi-target: chap auth shouldn't match username with trailing garbage
authorEric Seppanen <eric@purestorage.com>
Wed, 20 Nov 2013 22:19:52 +0000 (14:19 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Dec 2013 19:05:23 +0000 (11:05 -0800)
commitee265ec27a5727822118b040a980730a97de4bee
tree94a313599a24fd35833ec291d64664de139c08be
parent9457444765ff2125c970a92011f24f1eb20e75cc
iscsi-target: chap auth shouldn't match username with trailing garbage

commit 86784c6bdeeef78eed94d298be7a8879f6a97ee2 upstream.

In iSCSI negotiations with initiator CHAP enabled, usernames with
trailing garbage are permitted, because the string comparison only
checks the strlen of the configured username.

e.g. "usernameXXXXX" will be permitted to match "username".

Just check one more byte so the trailing null char is also matched.

Signed-off-by: Eric Seppanen <eric@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/target/iscsi/iscsi_target_auth.c