ALSA: firewire-digi00x: prevent potential use after free
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 9 May 2023 09:07:11 +0000 (12:07 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 May 2023 16:32:43 +0000 (17:32 +0100)
commitee1a221d947809c0308f27567c07a3ac93406057
tree48047215065957bd75b607b0d925c37cd77c52e1
parentea9c758184aebe46f3ab3bf318600be2b61f14bb
ALSA: firewire-digi00x: prevent potential use after free

[ Upstream commit c0e72058d5e21982e61a29de6b098f7c1f0db498 ]

This code was supposed to return an error code if init_stream()
failed, but it instead freed dg00x->rx_stream and returned success.
This potentially leads to a use after free.

Fixes: 9a08067ec318 ("ALSA: firewire-digi00x: support AMDTP domain")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/c224cbd5-d9e2-4cd4-9bcf-2138eb1d35c6@kili.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/firewire/digi00x/digi00x-stream.c