[FileCheck] Don't permit overlapping CHECK-DAG
authorJoel E. Denny <jdenny.ornl@gmail.com>
Wed, 11 Jul 2018 18:42:58 +0000 (18:42 +0000)
committerJoel E. Denny <jdenny.ornl@gmail.com>
Wed, 11 Jul 2018 18:42:58 +0000 (18:42 +0000)
commitedf338856cc6e542e515d7537090ebbbccbdce9f
tree08ca2b7f61b582206a51206119fd7d365111abd2
parent0f9ca2d9601fbbcbeea079f1782264019b8ad008
[FileCheck] Don't permit overlapping CHECK-DAG

That is, make CHECK-DAG skip matches that overlap the matches of any
preceding consecutive CHECK-DAG directives.  This change makes
CHECK-DAG more consistent with other directives, and there is evidence
it makes CHECK-DAG more intuitive and less error-prone.  See the RFC
discussion starting at:

  http://lists.llvm.org/pipermail/llvm-dev/2018-May/123010.html

Moreover, this behavior enables CHECK-DAG groups for unordered,
non-unique strings or patterns.  For example, it is useful for
verifying output or logs from a parallel program, such as the OpenMP
runtime.

This patch also implements the command-line option
-allow-deprecated-dag-overlap, which reverts CHECK-DAG to the old
overlapping behavior.  This option should not be used in new tests.
It is meant only for the existing tests that are broken by this change
and that need time to update.

See the following bugzilla issue for tracking of such tests:

  https://bugs.llvm.org/show_bug.cgi?id=37532

Patches to add -allow-deprecated-dag-overlap to those tests will
follow immediately.

Reviewed By: probinson

Differential Revision: https://reviews.llvm.org/D47106

llvm-svn: 336830
llvm/docs/CommandGuide/FileCheck.rst
llvm/test/FileCheck/check-dag-overlap-torture.txt [new file with mode: 0644]
llvm/test/FileCheck/check-dag-overlap.txt [new file with mode: 0644]
llvm/utils/FileCheck/FileCheck.cpp