main-loop: fix qemu_notify_event for aio_notify optimization
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 24 Jul 2015 11:42:55 +0000 (13:42 +0200)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 27 Jul 2015 16:12:19 +0000 (17:12 +0100)
commitedec47cfef96209987cb7922286cb384916aae02
tree72ba93a5e646a5b83526ecda1c5b16006c10c9b1
parent3737129917c918767cdb8acd8ca6b342c45fa154
main-loop: fix qemu_notify_event for aio_notify optimization

aio_notify can be optimized away, and in fact almost always will.  However,
qemu_notify_event is used in places where this is incorrect---most notably,
when handling SIGTERM.  When aio_notify is optimized away, it is possible that
QEMU enters a blocking ppoll immediately afterwards and stays there, without
reaching main_loop_should_exit().

Fix this by using a bottom half.  The bottom half can be optimized too, but
scheduling it is enough for the ppoll not to block.  The hang is thus avoided.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 1437738175-23624-1-git-send-email-pbonzini@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
main-loop.c