V4L/DVB (11841): core: fix potential mutex_unlock without mutex_lock in dvb_dvr_read
authorSimon Arlott <simon@fire.lp0.eu>
Tue, 12 May 2009 20:39:28 +0000 (17:39 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 16 Jun 2009 21:21:10 +0000 (18:21 -0300)
commiteda9f7523b6760bdfc3b9c5001214467b5ecd618
treebedaac0621dfdabfdf9d5bd0c4f0a37590d5e4de
parent1010ed132727bbf486ac28fd149ccfb0ef5cd2ab
V4L/DVB (11841): core: fix potential mutex_unlock without mutex_lock in dvb_dvr_read

dvb_dvr_read may unlock the dmxdev mutex and return -ENODEV, except this
function is a file op and will never be called with the mutex held.

There's existing mutex_lock and mutex_unlock around the actual read but
it's commented out.  These should probably be uncommented but the read
blocks and this could block another non-blocking reader on the mutex
instead.

This change comments out the extra mutex_unlock.

[akpm@linux-foundation.org: cleanups, simplification]
Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/dvb-core/dmxdev.c