net: stmmac: dwmac-meson8b: fix meson8b_devm_clk_prepare_enable()
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Fri, 4 Nov 2022 08:30:04 +0000 (09:30 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 8 Nov 2022 01:52:24 +0000 (17:52 -0800)
commited4314f7729714d788698ade4f9905ee5378ebc0
tree8847ed6b2fea921709ade5603089ff10b27e77ab
parentc23fb2c82267638f9d206cb96bb93e1f93ad7828
net: stmmac: dwmac-meson8b: fix meson8b_devm_clk_prepare_enable()

There are two problems with meson8b_devm_clk_prepare_enable(),
introduced in commit a54dc4a49045 ("net: stmmac: dwmac-meson8b:
Make the clock enabling code re-usable"):

- It doesn't pass the clk argument, but instead always the
  rgmii_tx_clk of the device.

- It silently ignores the return value of devm_add_action_or_reset().

The former didn't become an actual bug until another user showed up in
the next commit 9308c47640d5 ("net: stmmac: dwmac-meson8b: add support
for the RX delay configuration"). The latter means the callers could
end up with the clock not actually prepared/enabled.

Fixes: a54dc4a49045 ("net: stmmac: dwmac-meson8b: Make the clock enabling code re-usable")
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Link: https://lore.kernel.org/r/20221104083004.2212520-1-linux@rasmusvillemoes.dk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c