block, bfq: get extra ref to prevent a queue from being freed during a group move
authorPaolo Valente <paolo.valente@linaro.org>
Mon, 3 Feb 2020 10:40:56 +0000 (11:40 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 3 Feb 2020 13:58:15 +0000 (06:58 -0700)
commitecedd3d7e19911ab8fe42f17b77c0a30fe7f4db3
tree604e9e103322c6b4708d9fcf8ecd2e24be6c92e8
parent32c59e3a9a5a0b180dd015755d6d18ca31e55935
block, bfq: get extra ref to prevent a queue from being freed during a group move

In bfq_bfqq_move(), the bfq_queue, say Q, to be moved to a new group
may happen to be deactivated in the scheduling data structures of the
source group (and then activated in the destination group). If Q is
referred only by the data structures in the source group when the
deactivation happens, then Q is freed upon the deactivation.

This commit addresses this issue by getting an extra reference before
the possible deactivation, and releasing this extra reference after Q
has been moved.

Tested-by: Chris Evich <cevich@redhat.com>
Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-cgroup.c