[X86] make sure POP has implicit def/use of stack pointer when materializing 8-bit...
authorYuanfang Chen <yuanfang.chen@sony.com>
Sun, 29 Mar 2020 20:01:42 +0000 (13:01 -0700)
committerYuanfang Chen <yuanfang.chen@sony.com>
Mon, 30 Mar 2020 16:25:31 +0000 (09:25 -0700)
commitece79f47083babcabde3700c67b90ef19967a5b3
tree936b1c53f70c6d84fb890192dd3edc821cfaa6f6
parent1a1bb876dba41066f6e9a273c24fad04e0f9f2da
[X86] make sure POP has implicit def/use of stack pointer when materializing 8-bit immediates for minsize

Summary:
Otherwise PostRA list scheduler may reorder instruction, such as

schedule this
'''
pushq  $0x8
pop    %rbx
lea    0x2a0(%rsp),%r15
'''
to
'''
pushq  $0x8
lea    0x2a0(%rsp),%r15
pop    %rbx
'''
by mistake. The patch is to prevent this to happen by making sure POP has
implicit use of SP.

Reviewers: craig.topper

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77031
llvm/lib/Target/X86/X86InstrInfo.cpp
llvm/test/CodeGen/X86/materialize.ll