[media] m88ds3103: fix undefined division
authorPeter Rosin <peda@axentia.se>
Wed, 16 Mar 2016 12:14:13 +0000 (09:14 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Wed, 13 Apr 2016 22:17:39 +0000 (19:17 -0300)
commitecb7b0183a89613c154d1bea48b494907efbf8f9
tree3719495a0e9babac97e4f360a7571cc6a3fc4a2b
parent71c5daba0546c456c5589bcf52eb2641abf42a85
[media] m88ds3103: fix undefined division

s32tmp in the below code may be negative, and dev->mclk_khz is an
unsigned type.

s32tmp = 0x10000 * (tuner_frequency - c->frequency);
s32tmp = DIV_ROUND_CLOSEST(s32tmp, dev->mclk_khz);

This is undefined, as DIV_ROUND_CLOSEST is undefined for negative
dividends when the divisor is of unsigned type.

So, change mclk_khz to be signed (s32).

Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/dvb-frontends/m88ds3103_priv.h