Added connectivity files for full code review
authorAshok Channa <ashok.channa@samsung.com>
Wed, 4 Feb 2015 09:48:20 +0000 (18:48 +0900)
committerPatrick Lankswert <patrick.lankswert@intel.com>
Wed, 11 Mar 2015 22:40:59 +0000 (22:40 +0000)
commitec501972e17105287c868a34f452841f2ad1bb2a
tree42a05ca35f685069e1b41d2c496f90f465e23fa4
parentbb09189b4434e4aa18311705c78bcb50c3241167
Added connectivity files for full code review

Please comment on patch set 14 if any comments are not addressed
from 1~13.

NOTE:
1)Code Comments till Patch Set 13 are updated.
2)Please put your comments on new patch sets(at least from 13)  and
try to avoid on old patch sets as it difficult to review the old sets

Modified CA source files for review comments.
Updated documentation, return parameters with CAResult, optimization etc.
Global variable naming conventions ..

Change-Id: Id19ec37831ae46896b59007cdde07217b5d8696a
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/193
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
243 files changed:
resource/csdk/connectivity/RELEASE v0.7
resource/csdk/connectivity/api/cacommon.h
resource/csdk/connectivity/api/cainterface.h
resource/csdk/connectivity/build/How_To_Build.txt
resource/csdk/connectivity/build/Makefile
resource/csdk/connectivity/build/SConscript
resource/csdk/connectivity/build/android/README.txt
resource/csdk/connectivity/build/android/SConscript
resource/csdk/connectivity/build/android/jni/Android.mk
resource/csdk/connectivity/build/android/jni/Application.mk
resource/csdk/connectivity/build/arduino/Arduino_Setup_README.txt
resource/csdk/connectivity/build/arduino/Makefile
resource/csdk/connectivity/build/arduino/README.txt
resource/csdk/connectivity/build/arduino/SConscript
resource/csdk/connectivity/build/arduino/arduino.scons
resource/csdk/connectivity/build/arduino/arduinomega.properties
resource/csdk/connectivity/build/arduino/build.sh
resource/csdk/connectivity/build/arduino/local.properties
resource/csdk/connectivity/build/common.mk
resource/csdk/connectivity/build/linux/Makefile
resource/csdk/connectivity/build/linux/SConscript
resource/csdk/connectivity/build/linux/common.mk
resource/csdk/connectivity/build/tizen/Makefile
resource/csdk/connectivity/build/tizen/SConscript
resource/csdk/connectivity/build/tizen/com.oic.ca.manifest [new file with mode: 0644]
resource/csdk/connectivity/build/tizen/com.oic.ca.pc
resource/csdk/connectivity/build/tizen/gbsbuild.sh
resource/csdk/connectivity/build/tizen/packaging/com.oic.ca.spec
resource/csdk/connectivity/build/tizen/scons/SConscript
resource/csdk/connectivity/common/SConscript
resource/csdk/connectivity/common/inc/logger.h
resource/csdk/connectivity/common/inc/oic_console_logger.h
resource/csdk/connectivity/common/inc/oic_logger.h
resource/csdk/connectivity/common/inc/oic_logger_types.h
resource/csdk/connectivity/common/inc/oic_malloc.h
resource/csdk/connectivity/common/inc/oic_string.h
resource/csdk/connectivity/common/inc/uarraylist.h
resource/csdk/connectivity/common/inc/umutex.h
resource/csdk/connectivity/common/inc/uqueue.h
resource/csdk/connectivity/common/inc/uthreadpool.h
resource/csdk/connectivity/common/src/logger.c
resource/csdk/connectivity/common/src/oic_console_logger.c
resource/csdk/connectivity/common/src/oic_logger.c
resource/csdk/connectivity/common/src/oic_malloc.c
resource/csdk/connectivity/common/src/oic_string.c
resource/csdk/connectivity/common/src/uarraylist.c
resource/csdk/connectivity/common/src/umutex.c
resource/csdk/connectivity/common/src/uqueue.c
resource/csdk/connectivity/common/src/uthreadpool.c
resource/csdk/connectivity/doc/release/RELEASE v0.1 [deleted file]
resource/csdk/connectivity/doc/release/RELEASE v0.2 [deleted file]
resource/csdk/connectivity/doc/release/RELEASE v0.3 [deleted file]
resource/csdk/connectivity/doc/release/RELEASE v0.4 [deleted file]
resource/csdk/connectivity/doc/release/RELEASE v0.5 [deleted file]
resource/csdk/connectivity/doc/release/RELEASE v0.6 [deleted file]
resource/csdk/connectivity/external/inc/ocsecurityconfig.h
resource/csdk/connectivity/inc/caadapterinterface.h
resource/csdk/connectivity/inc/caadapternetdtls.h
resource/csdk/connectivity/inc/caadapterutils.h
resource/csdk/connectivity/inc/caedradapter.h
resource/csdk/connectivity/inc/caedradapter_singlethread.h
resource/csdk/connectivity/inc/caedrclient.h
resource/csdk/connectivity/inc/caedrinterface.h
resource/csdk/connectivity/inc/caedrserver.h
resource/csdk/connectivity/inc/caedrutils.h
resource/csdk/connectivity/inc/caethernetadapter.h
resource/csdk/connectivity/inc/caethernetadapter_singlethread.h
resource/csdk/connectivity/inc/caethernetinterface.h
resource/csdk/connectivity/inc/caethernetinterface_singlethread.h
resource/csdk/connectivity/inc/cainterfacecontroller.h
resource/csdk/connectivity/inc/cainterfacecontroller_singlethread.h
resource/csdk/connectivity/inc/caleadapter.h
resource/csdk/connectivity/inc/caleadapter_singlethread.h
resource/csdk/connectivity/inc/calecore.h
resource/csdk/connectivity/inc/caleinterface.h
resource/csdk/connectivity/inc/caleinterface_singlethread.h
resource/csdk/connectivity/inc/calenwmonitor.h
resource/csdk/connectivity/inc/caleserver.h
resource/csdk/connectivity/inc/caleutils.h
resource/csdk/connectivity/inc/camessagehandler.h
resource/csdk/connectivity/inc/camessagehandler_singlethread.h
resource/csdk/connectivity/inc/camsgparser.h
resource/csdk/connectivity/inc/canetworkconfigurator.h
resource/csdk/connectivity/inc/caprotocolmessage.h
resource/csdk/connectivity/inc/caprotocolmessage_singlethread.h
resource/csdk/connectivity/inc/caqueueingthread.h
resource/csdk/connectivity/inc/caremotehandler.h
resource/csdk/connectivity/inc/caretransmission.h
resource/csdk/connectivity/inc/caretransmission_singlethread.h
resource/csdk/connectivity/inc/cawifiadapter.h
resource/csdk/connectivity/inc/cawifiadapter_singlethread.h
resource/csdk/connectivity/inc/cawifiinterface.h
resource/csdk/connectivity/inc/cawifiinterface_singlethread.h
resource/csdk/connectivity/inc/com_iotivity_jar_CAWiFiInterface.h [deleted file]
resource/csdk/connectivity/lib/arduino/RBL_nRF8001.patch
resource/csdk/connectivity/lib/arduino/README.txt [deleted file]
resource/csdk/connectivity/lib/arduino/arduino_libraries.patch
resource/csdk/connectivity/lib/arduino/arduinomega.properties
resource/csdk/connectivity/lib/arduino/local.properties
resource/csdk/connectivity/lib/tizen/ble/inc/bluetooth.h [new file with mode: 0644]
resource/csdk/connectivity/lib/tizen/ble/inc/bluetooth_private.h [new file with mode: 0644]
resource/csdk/connectivity/lib/tizen/ble/inc/bluetooth_type.h [new file with mode: 0644]
resource/csdk/connectivity/lib/tizen/ble/inc/mobile/bluetooth_product.h [new file with mode: 0644]
resource/csdk/connectivity/lib/tizen/ble/inc/mobile/bluetooth_type_product.h [new file with mode: 0644]
resource/csdk/connectivity/samples/android/sample_app/Makefile [deleted file]
resource/csdk/connectivity/samples/android/sample_app/jni/Android.mk [deleted file]
resource/csdk/connectivity/samples/android/sample_app/jni/Application.mk [deleted file]
resource/csdk/connectivity/samples/android/sample_app/sample_main.c [deleted file]
resource/csdk/connectivity/samples/android/sample_service/AndroidManifest.xml
resource/csdk/connectivity/samples/android/sample_service/Makefile
resource/csdk/connectivity/samples/android/sample_service/jni/Android.mk
resource/csdk/connectivity/samples/android/sample_service/jni/Application.mk
resource/csdk/connectivity/samples/android/sample_service/jni/ResourceModel.c
resource/csdk/connectivity/samples/android/sample_service/jni/com_iotivity_service_RMInterface.h
resource/csdk/connectivity/samples/android/sample_service/proguard-project.txt
resource/csdk/connectivity/samples/android/sample_service/res/layout/activity_main.xml
resource/csdk/connectivity/samples/android/sample_service/res/menu/main.xml
resource/csdk/connectivity/samples/android/sample_service/res/values-v11/styles.xml
resource/csdk/connectivity/samples/android/sample_service/res/values-v14/styles.xml
resource/csdk/connectivity/samples/android/sample_service/res/values-w820dp/dimens.xml
resource/csdk/connectivity/samples/android/sample_service/res/values/dimens.xml
resource/csdk/connectivity/samples/android/sample_service/res/values/strings.xml
resource/csdk/connectivity/samples/android/sample_service/res/values/styles.xml
resource/csdk/connectivity/samples/android/sample_service/src/com/iotivity/jar/CALeInterface.java
resource/csdk/connectivity/samples/android/sample_service/src/com/iotivity/jar/CAWiFiInterface.java
resource/csdk/connectivity/samples/android/sample_service/src/com/iotivity/service/DLog.java
resource/csdk/connectivity/samples/android/sample_service/src/com/iotivity/service/MainActivity.java
resource/csdk/connectivity/samples/android/sample_service/src/com/iotivity/service/RMInterface.java
resource/csdk/connectivity/samples/arduino/SConscript
resource/csdk/connectivity/samples/arduino/casample.cpp
resource/csdk/connectivity/samples/arduino/sample_main.cpp [deleted file]
resource/csdk/connectivity/samples/linux/.gitignore [deleted file]
resource/csdk/connectivity/samples/linux/Makefile
resource/csdk/connectivity/samples/linux/README
resource/csdk/connectivity/samples/linux/SConscript
resource/csdk/connectivity/samples/linux/sample.sh
resource/csdk/connectivity/samples/linux/sample_main.c
resource/csdk/connectivity/samples/linux/threadpool/Makefile
resource/csdk/connectivity/samples/linux/threadpool/main.c
resource/csdk/connectivity/samples/tizen/Makefile
resource/csdk/connectivity/samples/tizen/README.txt
resource/csdk/connectivity/samples/tizen/SConscript
resource/csdk/connectivity/samples/tizen/SConstruct
resource/csdk/connectivity/samples/tizen/casample.c
resource/csdk/connectivity/samples/tizen/com.oic.ca.sample.manifest
resource/csdk/connectivity/samples/tizen/com.oic.ca.sample.rule [deleted file]
resource/csdk/connectivity/samples/tizen/com.oic.ca.sample.xml
resource/csdk/connectivity/samples/tizen/gbsbuild.sh
resource/csdk/connectivity/samples/tizen/interfacesample.c [deleted file]
resource/csdk/connectivity/samples/tizen/packaging/com.oic.ca.sample.spec
resource/csdk/connectivity/samples/tizen/scons/SConscript
resource/csdk/connectivity/src/SConscript
resource/csdk/connectivity/src/adapter_util/caadapternetdtls.c
resource/csdk/connectivity/src/adapter_util/caadapterutils.c
resource/csdk/connectivity/src/adapter_util/camsgparser.c
resource/csdk/connectivity/src/bt_edr_adapter/SConscript
resource/csdk/connectivity/src/bt_edr_adapter/android/caedrclient.c
resource/csdk/connectivity/src/bt_edr_adapter/android/caedrnwmonitor.c
resource/csdk/connectivity/src/bt_edr_adapter/android/caedrserver.c
resource/csdk/connectivity/src/bt_edr_adapter/android/caedrutils.c
resource/csdk/connectivity/src/bt_edr_adapter/caedradapter.c
resource/csdk/connectivity/src/bt_edr_adapter/linux/caedradapter.c
resource/csdk/connectivity/src/bt_edr_adapter/tizen/caedrclient.c
resource/csdk/connectivity/src/bt_edr_adapter/tizen/caedrdevicelist.c
resource/csdk/connectivity/src/bt_edr_adapter/tizen/caedrdevicelist.h
resource/csdk/connectivity/src/bt_edr_adapter/tizen/caedrendpoint.c
resource/csdk/connectivity/src/bt_edr_adapter/tizen/caedrendpoint.h
resource/csdk/connectivity/src/bt_edr_adapter/tizen/caedrnwmonitor.c
resource/csdk/connectivity/src/bt_edr_adapter/tizen/caedrserver.c
resource/csdk/connectivity/src/bt_edr_adapter/tizen/caedrutils.c
resource/csdk/connectivity/src/bt_edr_adapter/tizen/caedrutils.h
resource/csdk/connectivity/src/bt_le_adapter/SConscript
resource/csdk/connectivity/src/bt_le_adapter/android/caleadapter.c
resource/csdk/connectivity/src/bt_le_adapter/android/caleclient.c
resource/csdk/connectivity/src/bt_le_adapter/android/calenwmonitor.c
resource/csdk/connectivity/src/bt_le_adapter/android/caleserver.c
resource/csdk/connectivity/src/bt_le_adapter/android/caleutils.c
resource/csdk/connectivity/src/bt_le_adapter/android/com_iotivity_jar_caleinterface.h [moved from resource/csdk/connectivity/inc/com_iotivity_jar_CALeInterface.h with 63% similarity]
resource/csdk/connectivity/src/bt_le_adapter/arduino/cablenwmonitor.cpp
resource/csdk/connectivity/src/bt_le_adapter/arduino/cableserver.cpp
resource/csdk/connectivity/src/bt_le_adapter/arduino/cableserver.h
resource/csdk/connectivity/src/bt_le_adapter/caleadapter.c
resource/csdk/connectivity/src/bt_le_adapter/caleadapter_singlethread.c
resource/csdk/connectivity/src/bt_le_adapter/linux/caleadapter.c
resource/csdk/connectivity/src/bt_le_adapter/tizen/cableclient.c
resource/csdk/connectivity/src/bt_le_adapter/tizen/cableclient.h
resource/csdk/connectivity/src/bt_le_adapter/tizen/cablenwmonitor.c
resource/csdk/connectivity/src/bt_le_adapter/tizen/cableserver.c
resource/csdk/connectivity/src/bt_le_adapter/tizen/cableserver.h
resource/csdk/connectivity/src/bt_le_adapter/tizen/cableutil.c
resource/csdk/connectivity/src/bt_le_adapter/tizen/cableutil.h
resource/csdk/connectivity/src/caconnectivitymanager.c
resource/csdk/connectivity/src/caconnectivitymanager_singlethread.c
resource/csdk/connectivity/src/cainterfacecontroller.c
resource/csdk/connectivity/src/cainterfacecontroller_singlethread.c
resource/csdk/connectivity/src/camessagehandler.c
resource/csdk/connectivity/src/camessagehandler_singlethread.c
resource/csdk/connectivity/src/canetworkconfigurator.c
resource/csdk/connectivity/src/canetworkconfigurator_singlethread.c
resource/csdk/connectivity/src/caprotocolmessage.c
resource/csdk/connectivity/src/caprotocolmessage_singlethread.c
resource/csdk/connectivity/src/caqueueingthread.c
resource/csdk/connectivity/src/caremotehandler.c
resource/csdk/connectivity/src/caretransmission.c
resource/csdk/connectivity/src/caretransmission_singlethread.c [moved from resource/csdk/connectivity/src/caretransmission_singlethread.cpp with 77% similarity]
resource/csdk/connectivity/src/ethernet_adapter/SConscript
resource/csdk/connectivity/src/ethernet_adapter/arduino/caethernetadapterutils.cpp
resource/csdk/connectivity/src/ethernet_adapter/arduino/caethernetadapterutils.h
resource/csdk/connectivity/src/ethernet_adapter/arduino/caethernetclient.cpp
resource/csdk/connectivity/src/ethernet_adapter/arduino/caethernetnwmonitor.cpp
resource/csdk/connectivity/src/ethernet_adapter/arduino/caethernetserver.cpp
resource/csdk/connectivity/src/ethernet_adapter/caethernetadapter.c
resource/csdk/connectivity/src/ethernet_adapter/caethernetadapter_singlethread.c
resource/csdk/connectivity/src/ethernet_adapter/linux/caethernetclient.c
resource/csdk/connectivity/src/ethernet_adapter/linux/caethernetnwmonitor.c
resource/csdk/connectivity/src/ethernet_adapter/linux/caethernetserver.c
resource/csdk/connectivity/src/wifi_adapter/android/cawificlient.c
resource/csdk/connectivity/src/wifi_adapter/android/cawifinwmonitor.c
resource/csdk/connectivity/src/wifi_adapter/android/cawifiserver.c
resource/csdk/connectivity/src/wifi_adapter/android/com_iotivity_jar_cawifiinterface.h [new file with mode: 0644]
resource/csdk/connectivity/src/wifi_adapter/arduino/cawificlient.cpp
resource/csdk/connectivity/src/wifi_adapter/arduino/cawifinwmonitor.cpp
resource/csdk/connectivity/src/wifi_adapter/arduino/cawifiserver.cpp
resource/csdk/connectivity/src/wifi_adapter/cawifiadapter.c
resource/csdk/connectivity/src/wifi_adapter/cawifiadapter_singlethread.c
resource/csdk/connectivity/src/wifi_adapter/linux/cawificlient.c
resource/csdk/connectivity/src/wifi_adapter/linux/cawifinwmonitor.c
resource/csdk/connectivity/src/wifi_adapter/linux/cawifiserver.c
resource/csdk/connectivity/src/wifi_adapter/tizen/cawificlient.c
resource/csdk/connectivity/src/wifi_adapter/tizen/cawifinwmonitor.c
resource/csdk/connectivity/src/wifi_adapter/tizen/cawifiserver.c
resource/csdk/connectivity/unittests/linux/ca_api_unittest.cpp [new file with mode: 0644]
resource/csdk/connectivity/unittests/linux/sample1_unittest.cc [deleted file]
resource/csdk/connectivity/unittests/tizen/tct/README.txt [deleted file]
resource/csdk/connectivity/unittests/tizen/tct/liboic/CMakeLists.txt [deleted file]
resource/csdk/connectivity/unittests/tizen/tct/liboic/bt/utc-bt-liboic.c [deleted file]
resource/csdk/connectivity/unittests/tizen/tct/liboic/tct-liboic-core.c [deleted file]
resource/csdk/connectivity/unittests/tizen/tct/liboic/tct-liboic-core.h [deleted file]
resource/csdk/connectivity/unittests/tizen/tct/liboic/utc-liboic.c [deleted file]
resource/csdk/connectivity/unittests/tizen/tct/liboic/wifi/utc-wifi-liboic.c [deleted file]
resource/csdk/connectivity/unittests/tizen/tct/packaging/core-liboic-tests.spec [deleted file]
resource/csdk/stack/src/ocresource.c
resource/csdk/stack/src/ocserverrequest.c