projects / platform / upstream / ninja.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9017c5b) | patch
BuildLog: Use Log::insert(Log::value_type()) to avoid invalid strings.
authorEvan Jones <ej@evanjones.ca>
Fri, 13 Jan 2012 14:20:07 +0000 (09:20 -0500)
committerEvan Jones <ej@evanjones.ca>
Fri, 13 Jan 2012 14:20:07 +0000 (09:20 -0500)
commitec18376c7b6b1be44ad4c2055e0ee80aa711b884
treefbe5e0a64436660c5f14abe4e6841a29ec6db6ectree | snapshot
parent9017c5b46b1a865db58a9f29ce4bca79c9feb15acommit | diff
BuildLog: Use Log::insert(Log::value_type()) to avoid invalid strings.

The MSVC std::string implementation copies strings, so using make_pair
resulted in a pointer to invalid memory. This ensures the insert uses a
StringPiece without an intermediate std::string copy, so the correct pointer
ends up in the hash_map.
src/build_log.cc diff | blob | history
Domain: System / Base;