ring-buffer: Check pending waiters when doing wake ups as well
authorSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 27 Sep 2022 23:15:25 +0000 (19:15 -0400)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 27 Sep 2022 23:23:04 +0000 (19:23 -0400)
commitec0bbc5ec5664dcee344f79373852117dc672c86
tree1961405e6a075dc68eb4cad16f72677f4fea8aa3
parent3b19d614b61b93a131f463817e08219c9ce1fee3
ring-buffer: Check pending waiters when doing wake ups as well

The wake up waiters only checks the "wakeup_full" variable and not the
"full_waiters_pending". The full_waiters_pending is set when a waiter is
added to the wait queue. The wakeup_full is only set when an event is
triggered, and it clears the full_waiters_pending to avoid multiple calls
to irq_work_queue().

The irq_work callback really needs to check both wakeup_full as well as
full_waiters_pending such that this code can be used to wake up waiters
when a file is closed that represents the ring buffer and the waiters need
to be woken up.

Link: https://lkml.kernel.org/r/20220927231824.209460321@goodmis.org
Cc: stable@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Fixes: 15693458c4bc0 ("tracing/ring-buffer: Move poll wake ups into ring buffer code")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/ring_buffer.c