Revert "[lldb] Use vFlash commands when writing to target's flash memory regions"
authorPavel Labath <labath@google.com>
Wed, 28 Feb 2018 20:42:29 +0000 (20:42 +0000)
committerPavel Labath <labath@google.com>
Wed, 28 Feb 2018 20:42:29 +0000 (20:42 +0000)
commitec03d7e3babb18f222d9b83a04e747f206f416a5
tree242cc79fe6f09deb8ff99826bfb123cc331a4e65
parentfde8b042358ac2b8ac0b7c3a590e9471d3515462
Revert "[lldb] Use vFlash commands when writing to target's flash memory regions"

This reverts commit r326261 as it introduces inconsistencies in the
handling of load addresses for ObjectFileELF -- some parts of the class
use physical addresses, and some use virtual. This has manifested itself
as us not being able to set the load address of the vdso "module" on
android.

llvm-svn: 326367
13 files changed:
lldb/include/lldb/Host/XML.h
lldb/include/lldb/Target/MemoryRegionInfo.h
lldb/include/lldb/Target/Process.h
lldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteLoad.py [deleted file]
lldb/source/Host/common/XML.cpp
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.h
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
lldb/source/Symbol/ObjectFile.cpp
lldb/source/Target/Process.cpp