iommu/rockchip: Fix unwind goto issue
authorChao Wang <D202280639@hust.edu.cn>
Mon, 17 Apr 2023 03:04:21 +0000 (03:04 +0000)
committerJoerg Roedel <jroedel@suse.de>
Mon, 22 May 2023 15:03:08 +0000 (17:03 +0200)
commitec014683c564fb74fc68e8f5e84691d3b3839d24
treec8f4157e4c93819cbc283b0ce7f176cd03cd96dd
parente332003bb216a9f91e08004b9e2de0745f321290
iommu/rockchip: Fix unwind goto issue

Smatch complains that
drivers/iommu/rockchip-iommu.c:1306 rk_iommu_probe() warn: missing unwind goto?

The rk_iommu_probe function, after obtaining the irq value through
platform_get_irq, directly returns an error if the returned value
is negative, without releasing any resources.

Fix this by adding a new error handling label "err_pm_disable" and
use a goto statement to redirect to the error handling process. In
order to preserve the original semantics, set err to the value of irq.

Fixes: 1aa55ca9b14a ("iommu/rockchip: Move irq request past pm_runtime_enable")
Signed-off-by: Chao Wang <D202280639@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20230417030421.2777-1-D202280639@hust.edu.cn
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/rockchip-iommu.c