ASoC: wm_adsp: remove "ctl" from list on error in wm_adsp_create_control()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 9 Dec 2020 06:54:09 +0000 (09:54 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:53:50 +0000 (11:53 +0100)
commitebfeeb104facda4f6d8f9d241e8f8cc342f52821
tree68a2cdc99d63f9f19b2d2a80fe9d26a006101988
parent7fcf1c13802f26628d1a276f750fd1a9c7e08382
ASoC: wm_adsp: remove "ctl" from list on error in wm_adsp_create_control()

[ Upstream commit 85a7555575a0e48f9b73db310d0d762a08a46d63 ]

The error handling frees "ctl" but it's still on the "dsp->ctl_list"
list so that could result in a use after free.  Remove it from the list
before returning.

Fixes: 2323736dca72 ("ASoC: wm_adsp: Add basic support for rev 1 firmware file format")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/X9B0keV/02wrx9Xs@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/wm_adsp.c