usb: gadget: legacy: remove using list iterator after loop body as a ptr
authorJakob Koschel <jakobkoschel@gmail.com>
Tue, 8 Mar 2022 17:18:10 +0000 (18:18 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Mar 2022 17:19:44 +0000 (18:19 +0100)
commiteb6db9ccf6fb35f44f905d40ffbd667ddcc0e1cc
treeeb3eced8180631c126f28c21515092823eb90b40
parent36f4c25ce32ed8a2e6304ebee6246b7f0b3b9a6f
usb: gadget: legacy: remove using list iterator after loop body as a ptr

If the list does not contain the expected element, the value of
list_for_each_entry() iterator will not point to a valid structure.
To avoid type confusion in such case, the list iterator
scope will be limited to list_for_each_entry() loop.

In preparation to limiting scope of a list iterator to the list traversal
loop, use a dedicated pointer to point to the found element [1].
Determining if an element was found is then simply checking if
the pointer is != NULL instead of using the potentially bogus pointer.

Link: https://lore.kernel.org/all/YhdfEIwI4EdtHdym@kroah.com/
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20220308171818.384491-19-jakobkoschel@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/legacy/hid.c