Bug #680961 - Broken dispatching of EAuthenticationSession
authorMilan Crha <mcrha@redhat.com>
Mon, 25 Nov 2013 21:29:23 +0000 (22:29 +0100)
committerMilan Crha <mcrha@redhat.com>
Mon, 25 Nov 2013 21:31:36 +0000 (22:31 +0100)
commiteaf23db27e55eaeaf77a480b2f51512f090a7f76
treead37d32393a5200a140406aa7054e78a8c125bf5
parent1b52c6fbc12a2f8df84b4618eb4c3db963a49989
Bug #680961 - Broken dispatching of EAuthenticationSession

There was basically no error reporting from the server to the client
when any such occurred during authentication on the server side, thus
the client was left waiting for a response which never happened. Even
the 'dismiss' signal has a comment that it can be used for such cases,
it's not the right thing to do, because it hides the errors from a user,
thus he/she doesn't know that something went wrong. For that a new
ServerError signal was added and the error is properly propagated to
the client. Note the GOA errors don't strip the GDBus error from
the message, which looks odd in the UI, thus I added a workaround
for that too.
libebackend/e-authentication-mediator.c
libebackend/e-authentication-mediator.h
libebackend/e-source-registry-server.c
libedataserver/e-source-registry.c
modules/gnome-online-accounts/e-goa-password-based.c
private/org.gnome.evolution.dataserver.Authenticator.xml