Fortran: Fix some of the bugs in associate [PR87477]
authorPaul Thomas <pault@gcc.gnu.org>
Sat, 8 Apr 2023 08:04:13 +0000 (09:04 +0100)
committerPaul Thomas <pault@gcc.gnu.org>
Sat, 8 Apr 2023 08:04:13 +0000 (09:04 +0100)
commiteac493851f07df98213ecf67a5e9ab41a7babcd2
tree7146895eed8a0c1417490f20a8e6f17be08b8884
parent46fe32cb4d887d44a62f9c4ff2a72532d4eb5a19
Fortran: Fix some of the bugs in associate [PR87477]

2023-04-08  Paul Thomas  <pault@gcc.gnu.org>

gcc/fortran
PR fortran/87477
* iresolve.cc (gfc_resolve_adjustl, gfc_resolve_adjustr): if
string length is deferred use the string typespec for result.
* resolve.cc (resolve_assoc_var): Handle parentheses around the
target expression.
(resolve_block_construct): Remove unnecessary static decls.
* trans-array.cc (gfc_conv_expr_descriptor): Guard string len
expression in condition. Improve handling of string length and
span, especially for substrings of the descriptor.
(duplicate_allocatable): Make element type more explicit with
'eltype'.
* trans-decl.cc (gfc_get_symbol_decl): Emit a fatal error with
appropriate message instead of ICE if symbol type is unknown.
(gfc_generate_function_code): Set current locus to proc_sym
declared_at.
* trans-expr.cc (gfc_get_expr_charlen): Retain last charlen in
'previous' and use if end expression in substring reference is
null.
(gfc_conv_string_length): Use gfc_conv_expr_descriptor if
'expr_flat' is an array. Add post block to catch deallocation
of temporaries.
(gfc_conv_procedure_call): Assign the parmse string length to
the expression string length, if it is deferred.
(gfc_trans_alloc_subarray_assign): If this is a deferred string
length component, store the string length in the hidden comp.
Update the typespec length accordingly. Generate a new type
spec for the call to gfc_duplicate-allocatable in this case.
* trans-io.cc (gfc_trans_transfer): Scalarize transfer of
deferred character array components.

gcc/testsuite/
PR fortran/87477
* gfortran.dg/associate_47.f90 : Enable substring test.
* gfortran.dg/associate_51.f90 : Update an error message.
* gfortran.dg/goacc/array-with-dt-2.f90 : Add span to
uninitialzed dg-warnings.

PR fortran/85686
PR fortran/88247
PR fortran/91941
PR fortran/92779
PR fortran/93339
PR fortran/93813
PR fortran/100948
PR fortran/102106
* gfortran.dg/associate_60.f90 : New test

PR fortran/98408
* gfortran.dg/pr98408.f90 : New test

PR fortran/105205
* gfortran.dg/pr105205.f90 : New test

PR fortran/106918
* gfortran.dg/pr106918.f90 : New test
13 files changed:
gcc/fortran/iresolve.cc
gcc/fortran/resolve.cc
gcc/fortran/trans-array.cc
gcc/fortran/trans-decl.cc
gcc/fortran/trans-expr.cc
gcc/fortran/trans-io.cc
gcc/testsuite/gfortran.dg/associate_47.f90
gcc/testsuite/gfortran.dg/associate_51.f90
gcc/testsuite/gfortran.dg/associate_60.f90 [new file with mode: 0644]
gcc/testsuite/gfortran.dg/goacc/array-with-dt-2.f90
gcc/testsuite/gfortran.dg/pr105205.f90 [new file with mode: 0644]
gcc/testsuite/gfortran.dg/pr106918.f90 [new file with mode: 0644]
gcc/testsuite/gfortran.dg/pr98408.f90 [new file with mode: 0644]