Annotate System.Data.{Odbc,OleDb} for nullability (#39597)
authorShay Rojansky <roji@roji.org>
Mon, 27 Jul 2020 09:09:50 +0000 (12:09 +0300)
committerGitHub <noreply@github.com>
Mon, 27 Jul 2020 09:09:50 +0000 (12:09 +0300)
commitea96ee3d86366ba21a5919101f64cc093a762fce
tree70f50aa832c21f742d73634eebaaaa594473e14a
parentd7bfb8ca0fd5a50acc1164d114343449a3f2c108
Annotate System.Data.{Odbc,OleDb} for nullability (#39597)

* Annotate System.Data.Odbc for nullability
* Annotate System.Data.OleDb for nullability
* Suppress nullable warnings on netcoreapp < 3.0
* Mark System.Data.DataSetExtensions as null-annotated
* Fix null-check bug in System.Data.OleDb
128 files changed:
src/libraries/Common/src/Interop/Interop.Odbc.cs
src/libraries/Common/src/System/Data/Common/AdapterUtil.Drivers.cs
src/libraries/Common/src/System/Data/Common/AdapterUtil.cs
src/libraries/Common/src/System/Data/Common/BasicFieldNameLookup.cs
src/libraries/Common/src/System/Data/Common/DbConnectionOptions.Common.cs
src/libraries/Common/src/System/Data/Common/DbConnectionPoolKey.cs
src/libraries/Common/src/System/Data/Common/FieldNameLookup.cs
src/libraries/Common/src/System/Data/Common/MultipartIdentifier.cs
src/libraries/Common/src/System/Data/Common/NameValuePair.cs
src/libraries/Common/src/System/Data/ProviderBase/DbConnectionClosed.cs
src/libraries/Common/src/System/Data/ProviderBase/DbConnectionFactory.cs
src/libraries/Common/src/System/Data/ProviderBase/DbConnectionInternal.cs
src/libraries/Common/src/System/Data/ProviderBase/DbConnectionPoolGroup.cs
src/libraries/Common/src/System/Data/ProviderBase/DbMetaDataFactory.cs
src/libraries/Common/src/System/Data/ProviderBase/DbReferenceCollection.cs
src/libraries/Directory.Build.targets
src/libraries/System.Data.Common/ref/System.Data.Common.cs
src/libraries/System.Data.Common/src/System/Data/Common/DBCommandBuilder.cs
src/libraries/System.Data.Common/src/System/Data/Common/DbDataAdapter.cs
src/libraries/System.Data.Common/src/System/Data/Common/RowUpdatedEventArgs.cs
src/libraries/System.Data.Common/src/System/Data/ConstraintCollection.cs
src/libraries/System.Data.Common/src/System/Data/DataRow.cs
src/libraries/System.Data.Common/src/System/Data/DataTable.cs
src/libraries/System.Data.Common/src/System/Data/ProviderBase/SchemaMapping.cs
src/libraries/System.Data.Common/src/System/Data/RecordManager.cs
src/libraries/System.Data.Common/src/System/Data/Select.cs
src/libraries/System.Data.DataSetExtensions/ref/System.Data.DataSetExtensions.csproj
src/libraries/System.Data.DataSetExtensions/src/System.Data.DataSetExtensions.csproj
src/libraries/System.Data.Odbc/ref/System.Data.Odbc.cs
src/libraries/System.Data.Odbc/ref/System.Data.Odbc.csproj
src/libraries/System.Data.Odbc/src/Common/System/Data/Common/AdapterUtil.Odbc.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/Common/DBConnectionString.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/Common/DbConnectionOptions.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/Common/DbConnectionStringCommon.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/Common/NameValuePermission.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/ProviderBase/DbBuffer.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/ProviderBase/DbConnectionFactory.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/ProviderBase/DbConnectionInternal.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/ProviderBase/DbConnectionPool.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/ProviderBase/DbConnectionPoolGroupProviderInfo.cs
src/libraries/System.Data.Odbc/src/Common/System/Data/ProviderBase/DbConnectionPoolIdentity.cs
src/libraries/System.Data.Odbc/src/System.Data.Odbc.csproj
src/libraries/System.Data.Odbc/src/System/Data/Odbc/DbDataRecord.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/Odbc32.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcCommand.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcCommandBuilder.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnection.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnectionFactory.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnectionHelper.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnectionOpen.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnectionPoolProviderInfo.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnectionString.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnectionStringbuilder.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcDataAdapter.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcDataReader.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcEnvironment.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcError.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcErrorCollection.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcException.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcHandle.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcMetaDataFactory.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcParameter.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcParameterCollection.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcParameterCollectionHelper.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcParameterHelper.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcRowUpdatingEvent.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcStatementHandle.cs
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcTransaction.cs
src/libraries/System.Data.OleDb/ref/System.Data.OleDb.cs
src/libraries/System.Data.OleDb/ref/System.Data.OleDb.csproj
src/libraries/System.Data.OleDb/src/AdapterSwitches.cs
src/libraries/System.Data.OleDb/src/ColumnBinding.cs
src/libraries/System.Data.OleDb/src/DbBindings.cs
src/libraries/System.Data.OleDb/src/DbConnectionOptions.cs
src/libraries/System.Data.OleDb/src/DbConnectionStringCommon.cs
src/libraries/System.Data.OleDb/src/DbParameterHelper.cs
src/libraries/System.Data.OleDb/src/DbPropSet.cs
src/libraries/System.Data.OleDb/src/NativeMethods.cs
src/libraries/System.Data.OleDb/src/OleDbCommand.cs
src/libraries/System.Data.OleDb/src/OleDbCommandBuilder.cs
src/libraries/System.Data.OleDb/src/OleDbConnection.cs
src/libraries/System.Data.OleDb/src/OleDbConnectionFactory.cs
src/libraries/System.Data.OleDb/src/OleDbConnectionInternal.cs
src/libraries/System.Data.OleDb/src/OleDbConnectionPoolGroupProviderInfo.cs
src/libraries/System.Data.OleDb/src/OleDbConnectionString.cs
src/libraries/System.Data.OleDb/src/OleDbConnectionStringBuilder.cs
src/libraries/System.Data.OleDb/src/OleDbDataAdapter.cs
src/libraries/System.Data.OleDb/src/OleDbDataReader.cs
src/libraries/System.Data.OleDb/src/OleDbEnumerator.cs
src/libraries/System.Data.OleDb/src/OleDbError.cs
src/libraries/System.Data.OleDb/src/OleDbErrorCollection.cs
src/libraries/System.Data.OleDb/src/OleDbException.cs
src/libraries/System.Data.OleDb/src/OleDbInfoMessageEvent.cs
src/libraries/System.Data.OleDb/src/OleDbMetaDataFactory.cs
src/libraries/System.Data.OleDb/src/OleDbParameter.cs
src/libraries/System.Data.OleDb/src/OleDbParameterCollection.cs
src/libraries/System.Data.OleDb/src/OleDbParameterCollectionHelper.cs
src/libraries/System.Data.OleDb/src/OleDbRowUpdatedEvent.cs
src/libraries/System.Data.OleDb/src/OleDbRowUpdatingEvent.cs
src/libraries/System.Data.OleDb/src/OleDbStruct.cs
src/libraries/System.Data.OleDb/src/OleDbTransaction.cs
src/libraries/System.Data.OleDb/src/OleDbWrapper.cs
src/libraries/System.Data.OleDb/src/OleDb_Enum.cs
src/libraries/System.Data.OleDb/src/OleDb_Util.cs
src/libraries/System.Data.OleDb/src/PropertyInfoSet.cs
src/libraries/System.Data.OleDb/src/RowBinding.cs
src/libraries/System.Data.OleDb/src/SafeHandles.cs
src/libraries/System.Data.OleDb/src/System.Data.OleDb.csproj
src/libraries/System.Data.OleDb/src/System/Data/Common/AdapterUtil.cs
src/libraries/System.Data.OleDb/src/System/Data/Common/DbConnectionPoolKey.cs
src/libraries/System.Data.OleDb/src/System/Data/Common/FieldNameLookup.cs
src/libraries/System.Data.OleDb/src/System/Data/Common/NameValuePair.cs
src/libraries/System.Data.OleDb/src/System/Data/Common/SR.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbBuffer.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionClosed.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionFactory.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionHelper.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionInternal.Shared.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionInternal.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionPool.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionPoolCounters.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionPoolGroup.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionPoolGroupProviderInfo.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbConnectionPoolIdentity.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbMetaDataFactory.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/DbReferenceCollection.cs
src/libraries/System.Data.OleDb/src/System/Data/ProviderBase/WrappedIUnknown.cs
src/libraries/System.Data.OleDb/src/UnsafeNativeMethods.cs