projects / platform / core / csapi / xsf.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ca995ae) | patch
[Android] Correctly dispose TabbedPageRenderer (#4974)
authorKevin Petit <kevin.petit@outlook.com>
Tue, 3 Sep 2019 16:25:46 +0000 (18:25 +0200)
committerShane Neuville <shneuvil@microsoft.com>
Tue, 3 Sep 2019 16:25:46 +0000 (10:25 -0600)
commitea78ad5794f2e6ccff3fab403b77979dd5b1e455
tree246a396f8d863906344521d148a84172fe83b374tree | snapshot
parentca995aecb658fe042fdbe476167fe513ae7c04b2commit | diff
[Android] Correctly dispose TabbedPageRenderer (#4974)

* Correctly dispose TabbedPageRenderer.
The fragments created are now removed and the listeners are now correctly cleaned during dispose.

* Added issue UI test.

* Fix carousel fragment manager and pager disposing.

* Fix test 2338 implementation.

* Apply review.

* Set to null fragmentManager on dispose.

* Use GetFragmentManager extension method.

Co-Authored-By: Shane Neuville <shane94@hotmail.com>
* Revert some changes.

* Apply review comment.
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2338.cs diff | blob | history
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue4973.cs [new file with mode: 0644] blob
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems diff | blob | history
Xamarin.Forms.Platform.Android/AppCompat/CarouselPageRenderer.cs diff | blob | history
Xamarin.Forms.Platform.Android/AppCompat/FormsFragmentPagerAdapter.cs diff | blob | history
Domain: Dotnet / UI;